[PATCH v7 0/5] clocksource/timer-econet-en751221: Support irq number per timer
Caleb James DeLisle <[email protected]> Fri, 31 Jul 2026 12:02:41 +0000
| Newsgroups | org.kernel.vger.linux-mips,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
This timer appears on both the EcoNet EN751221 (34Kc) and on the EN751627 / EN7528 (1004Kc) SoCs. On the 34Kc the interrupt controller uses a percpu interrupt while on the others it uses an individual IRQ number for each CPU timer. Add support for EN751627 and EN7528. Add support for IRQ number for each CPU timer under the econet,en751627-timer compatible. Changes since v6: * Rebase to tip/timers/core (base-commit below) Changes since v5: * Integrate patch fix refcount leak from: Link: https://lore.kernel.org/linux-mips/[email protected]/ * NULL econet_timer.membase after unmapping * NULL check dev->event_handler in case clockevents_config_and_register failed to fully register. * v5: https://lore.kernel.org/linux-mips/[email protected]/ Changes from v4: * Fixed incorrect compatible in DT schema * Bracing in out_irq_free if statement * I did not move cpuhp_setup_state past the point of no return * v4: https://lore.kernel.org/linux-mips/[email protected] Changes from v3: * off-by-one in out_irq_free * Gracefully fail if too many address resources are provided in the DT * Allow fewer actual timers than num_possible_cpus, as long as they never start * v3: https://lore.kernel.org/linux-mips/[email protected] v3 note: I decided to take this patchset in a slightly different direction from v2. There is a certain amount of initialization that once it has run, it cannot be reverted in case of error. The original driver init was a mixture of revertible and non-revertible code which made it too easy for code which is designed with best practices in mind to in fact introduce a bug. Therefore I start by making the init process more legible but without any business logic changes, then fix a race condition by keeping IRQ disabled until after cevt is setup, then finally add non-percpu IRQ support. * v2: https://lore.kernel.org/linux-mips/[email protected] Changes from v1: * Split changes over 3 refactoring patches + main patch * Remove driver discussion from dt commit message * v1: https://lore.kernel.org/linux-mips/[email protected]/ Alexander A. Klimov (1): clocksource/timer-econet-en751221: fix refcount leak Caleb James DeLisle (4): dt-bindings: timer: econet: Update EN751627 for multi-IRQ clocksource/timer-econet-en751221: Init teardown on error if possible clocksource/timer-econet-en751221: Disable IRQ until cevt registered clocksource/timer-econet-en751221: Support EN751627 without percpu IRQ .../bindings/timer/econet,en751221-timer.yaml | 31 +-- drivers/clocksource/timer-econet-en751221.c | 181 ++++++++++++++---- 2 files changed, 159 insertions(+), 53 deletions(-) base-commit: ecc330e3096173f433659aa64ab3674d0d48440e -- 2.39.5