Re: [PATCH bpf-next v3 2/3] MIPS: uasm: Add signed div/mod emitters

> diff --git a/arch/mips/mm/uasm.c b/arch/mips/mm/uasm.c
> index 125140979d62..06d722665451 100644
> --- a/arch/mips/mm/uasm.c
> +++ b/arch/mips/mm/uasm.c
> @@ -49,18 +49,20 @@ enum opcode {
>  	insn_addiu, insn_addu, insn_and, insn_andi, insn_bbit0, insn_bbit1,
>  	insn_beq, insn_beql, insn_bgez, insn_bgezl, insn_bgtz, insn_blez,
>  	insn_bltz, insn_bltzl, insn_bne, insn_break, insn_cache, insn_cfc1,
> -	insn_cfcmsa, insn_ctc1, insn_ctcmsa, insn_daddiu, insn_daddu, insn_ddivu,
> -	insn_ddivu_r6, insn_di, insn_dins, insn_dinsm, insn_dinsu, insn_divu,
> -	insn_divu_r6, insn_dmfc0, insn_dmodu, insn_dmtc0, insn_dmultu,
> +	insn_cfcmsa, insn_ctc1, insn_ctcmsa, insn_daddiu, insn_daddu, insn_ddiv,
> +	insn_ddiv_r6, insn_ddivu, insn_ddivu_r6, insn_di, insn_dins, insn_dinsm,
> +	insn_dinsu, insn_div, insn_div_r6, insn_divu, insn_divu_r6, insn_dmfc0,
> +	insn_dmod, insn_dmodu, insn_dmtc0, insn_dmultu,
>  	insn_dmulu, insn_drotr, insn_drotr32, insn_dsbh, insn_dshd, insn_dsll,
>  	insn_dsll32, insn_dsllv, insn_dsra, insn_dsra32, insn_dsrav, insn_dsrl,
>  	insn_dsrl32, insn_dsrlv, insn_dsubu, insn_eret, insn_ext, insn_ins,
>  	insn_j, insn_jal, insn_jalr, insn_jr, insn_lb, insn_lbu, insn_ld,
>  	insn_lddir, insn_ldpte, insn_ldx, insn_lh, insn_lhu, insn_ll, insn_lld,
>  	insn_lui, insn_lw, insn_lwu, insn_lwx, insn_mfc0, insn_mfhc0, insn_mfhi,
> -	insn_mflo, insn_modu, insn_movn, insn_movz, insn_mtc0, insn_mthc0,
> -	insn_mthi, insn_mtlo, insn_mul, insn_multu, insn_mulu, insn_muhu, insn_nor,
> -	insn_or, insn_ori, insn_pref, insn_rfe, insn_rotr, insn_sb, insn_sc,
> +	insn_mflo, insn_mod, insn_modu, insn_movn, insn_movz, insn_mtc0,
> +	insn_mthc0, insn_mthi, insn_mtlo, insn_mul, insn_multu, insn_mulu,
> +	insn_muhu, insn_nor, insn_or, insn_ori, insn_pref, insn_rfe, insn_rotr,
> +	insn_sb, insn_sc,

This isn't a bug, but the rewrap of the enum opcode list leaves two lines
considerably shorter than the surrounding ones. The line starting with
insn_dmod ends at 55 columns and the line starting with insn_sb ends at
25 columns, while most neighbouring lines in the same enum are packed to
70-80 columns. Would carrying the reflow through to maintain consistent
line density help keep the diff tighter?


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/31428094680