Re: [PATCH bpf-next v3 0/3] bpf, mips: Add signed div/mod support

Nicholas Dudar <[email protected]>
Newsgroups org.kernel.vger.linux-mips,org.kernel.vger.bpf,org.kernel.vger.linux-kernel
Message-ID <CAJZwKkis=3NGw9At0WfiZaRYEoMPbQfqJKN0e+vtRDvp4VY5Ng@mail.gmail.com>
> Please proceed with the remaining opcodes in the meantime. I will do
> the same on my part as we discussed, and then we can wrap up this
> whole v4 compliance work when I am back.

Sorry to bother you while you're away, I hope the holiday is going well.
No rush on this, but one ordering dependency fell out of my testing.
MOVSX and SDIV/SMOD need to land before MEMSX, BSWAP, or JMP32_JA.

MEMSX, BSWAP, and JMP32_JA are currently unhandled, so any program
containing one causes the MIPS JIT to abandon compilation. Adding support
for one removes the fallback, so a mixed program can reach the existing
MOV or DIV/MOD paths before their off encodings are supported and be
miscompiled.

I plan to post MOVSX today. For MEMSX, I will base it after MOVSX and
SDIV/SMOD and call out the dependency in the commit message. This avoids
carrying a temporary fail-closed check. Does that ordering work for BSWAP
and JMP32_JA?

Thanks,
Nick
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.