Re: [PATCH] [RFC] gpiolib: introduce gpio_name() helper
"Arnd Bergmann" <[email protected]>
| Newsgroups | org.kernel.vger.linux-mmc,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-gpio,org.kernel.vger.linux-i2c,org.kernel.vger.linux-iio,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm,org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jun 29, 2026, at 17:29, Geert Uytterhoeven wrote: > On Mon, 29 Jun 2026 at 15:59, Arnd Bergmann <[email protected]> wrote: >> From: Arnd Bergmann <[email protected]> >> >> Most remaining users of desc_to_gpio() only call it for printing debug >> information. >> >> Replace this with a new gpiod_name() helper that returns the >> gpio_desc->name string after checking the gpio_desc pointer. >> >> Signed-off-by: Arnd Bergmann <[email protected]> > > Thanks for your patch! Thanks for testing! >> --- a/drivers/gpio/gpio-aggregator.c >> +++ b/drivers/gpio/gpio-aggregator.c >> @@ -758,8 +758,8 @@ int gpiochip_fwd_desc_add(struct gpiochip_fwd *fwd, struct gpio_desc *desc, >> >> fwd->descs[offset] = desc; >> >> - dev_dbg(chip->parent, "%u => gpio %d irq %d\n", offset, >> - desc_to_gpio(desc), gpiod_to_irq(desc)); >> + dev_dbg(chip->parent, "%u => gpio %s irq %d\n", offset, >> + gpiod_name(desc), gpiod_to_irq(desc)); >> >> return 0; >> } > > Before, this printed: > > gpio-aggregator gpio-aggregator.1: 0 => gpio 589 irq 188 > gpio-aggregator gpio-aggregator.1: 1 => gpio 590 irq 189 > > After, this prints: > > gpio-aggregator gpio-aggregator.1: 0 => gpio (null) irq 188 > gpio-aggregator gpio-aggregator.1: 1 => gpio (null) irq 189 > > Same results for instantiation using sysfs or configfs[1], although > the latter does have optional support for specifying the name. I wonder how many of the other instances have the same problem then. Would it be appropriate for gpiochip_fwd_desc_add() to set a name itself to address this one? Arnd