Re: [PATCH v2 3/6] firmware: qcom: scm: Add support for setting Bluetooth power modes
Konrad Dybcio <[email protected]>
| Newsgroups | org.kernel.vger.linux-mmc,org.infradead.lists.ath10k,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-block,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-remoteproc,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 7/1/26 3:15 PM, George Moussalem wrote: > On 7/1/26 14:40, Konrad Dybcio wrote: >> On 6/29/26 3:01 PM, George Moussalem via B4 Relay wrote: >>> From: George Moussalem <[email protected]> >>> >>> The Bluetooth subsystem (BTSS) on the IPQ5018 SoC supports setting power >>> modes which are required to be configured through a Secure Channel >>> Manager (SCM) call to TrustZone. However, not all Trusted Execution >>> Environment (QSEE) images support this call, so first check if the call >>> is available. >>> >>> Signed-off-by: George Moussalem <[email protected]> >>> --- >> >> I'm amazed changing this setting is a secure operation >> >> [...] >> >>> +/** >>> + * qcom_scm_pas_set_bluetooth_power_mode() - Configure power optimization mode >>> + * for the Bluetooth subsystem (BTSS) >>> + * @pas_id: peripheral authentication service id >>> + * @val: 0x0 for normal operation, 0x4 for ECO mode >> >> If there's just two values, maybe we should make this take a `bool eco_mode`? > > that was the direction I was going in initially but then thought that > there may be more (undocumented) power modes I'm unaware off so changed > it to u32. I'll change it back to bool. We can always change back if needed Konrad