Re: [PATCH] mmc: dw_mmc: add declaration of dw_mci_pmops

Ulf Hansson <[email protected]> Mon, 6 Jul 2026 16:30:30 +0200

Newsgroups	org.kernel.vger.linux-mmc,org.kernel.vger.linux-kernel
Message-ID	<CAPx+jO9BtwN+=Y_xLFXusTwFFv=5KDZCY_3QmSpRmskMch3W6A@mail.gmail.com>

On Tue, Jun 23, 2026 at 12:24 PM Ben Dooks <[email protected]> wrote:
>
> The dw_mci_pmops is exported out of dw_mmc.c so add a declaration of
> it in dw_mmc.h to fix the following sparse warning:
>
> drivers/mmc/host/dw_mmc.c:3512:25: warning: symbol 'dw_mci_pmops' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <[email protected]>
> ---
>  drivers/mmc/host/dw_mmc.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
> index 9ffcd3946cff..38610c89d54a 100644
> --- a/drivers/mmc/host/dw_mmc.h
> +++ b/drivers/mmc/host/dw_mmc.h
> @@ -19,6 +19,8 @@
>  #include <linux/interrupt.h>
>  #include <linux/workqueue.h>
>
> +extern const struct dev_pm_ops dw_mci_pmops;
> +

It's already extern declared in drivers/mmc/host/dw_mmc-pltfm.h.
Perhaps drop that then?

>  enum dw_mci_state {
>         STATE_IDLE = 0,
>         STATE_SENDING_CMD,
> --
> 2.37.2.352.g3c44437643
>

Kind regards
Uffe