Re: [PATCH] mmc: dw_mmc: add declaration of dw_mci_pmops

Ulf Hansson <[email protected]> Tue, 7 Jul 2026 12:21:24 +0200

Newsgroups	org.kernel.vger.linux-mmc,org.kernel.vger.linux-kernel
Message-ID	<CAPx+jO_RNVWK=6UrrOWfpUseA+tFdMRQ18CysgzLS_WnDxiRHg@mail.gmail.com>

On Mon, Jul 6, 2026 at 8:25 PM Ben Dooks <[email protected]> wrote:
>
> On 06/07/2026 15:30, Ulf Hansson wrote:
> > On Tue, Jun 23, 2026 at 12:24 PM Ben Dooks <[email protected]> wrote:
> >>
> >> The dw_mci_pmops is exported out of dw_mmc.c so add a declaration of
> >> it in dw_mmc.h to fix the following sparse warning:
> >>
> >> drivers/mmc/host/dw_mmc.c:3512:25: warning: symbol 'dw_mci_pmops' was not declared. Should it be static?
> >>
> >> Signed-off-by: Ben Dooks <[email protected]>
> >> ---
> >>   drivers/mmc/host/dw_mmc.h | 2 ++
> >>   1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
> >> index 9ffcd3946cff..38610c89d54a 100644
> >> --- a/drivers/mmc/host/dw_mmc.h
> >> +++ b/drivers/mmc/host/dw_mmc.h
> >> @@ -19,6 +19,8 @@
> >>   #include <linux/interrupt.h>
> >>   #include <linux/workqueue.h>
> >>
> >> +extern const struct dev_pm_ops dw_mci_pmops;
> >> +
> >
> > It's already extern declared in drivers/mmc/host/dw_mmc-pltfm.h.
> > Perhaps drop that then?
>
> so just move it into dw_mmc.h?

Yes, that seems reasonable to me.

[...]

Kind regards
Uffe