Re: [PATCH v2] mmc: dw_mmc: move declaration of dw_mci_pmops
Ulf Hansson <[email protected]> Mon, 13 Jul 2026 13:25:37 +0200
| Newsgroups | org.kernel.vger.linux-mmc,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAPx+jO9sjDisn1Dg-UhzMOTy9wUVw8bFvDqmbkhF_Q=btiKj4Q@mail.gmail.com> |
On Fri, Jul 10, 2026 at 6:13 PM Ben Dooks <[email protected]> wrote: > > The dw_mci_pmops is exported out of dw_mmc.c so move the declaration of > ton dw_mmc.h from dw_mmc-pltfm.h to fix the following sparse warning: > > drivers/mmc/host/dw_mmc.c:3512:25: warning: symbol 'dw_mci_pmops' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <[email protected]> Applied for next, thanks! Kind regards Uffe > --- > v2: > - changed to moving the definition and re-worded commit > --- > drivers/mmc/host/dw_mmc-pltfm.h | 1 - > drivers/mmc/host/dw_mmc.h | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc-pltfm.h b/drivers/mmc/host/dw_mmc-pltfm.h > index ef1b05d484c3..f3193662abf1 100644 > --- a/drivers/mmc/host/dw_mmc-pltfm.h > +++ b/drivers/mmc/host/dw_mmc-pltfm.h > @@ -11,6 +11,5 @@ > extern int dw_mci_pltfm_register(struct platform_device *pdev, > const struct dw_mci_drv_data *drv_data); > extern void dw_mci_pltfm_remove(struct platform_device *pdev); > -extern const struct dev_pm_ops dw_mci_pmops; > > #endif /* _DW_MMC_PLTFM_H_ */ > diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h > index 9ffcd3946cff..38610c89d54a 100644 > --- a/drivers/mmc/host/dw_mmc.h > +++ b/drivers/mmc/host/dw_mmc.h > @@ -19,6 +19,8 @@ > #include <linux/interrupt.h> > #include <linux/workqueue.h> > > +extern const struct dev_pm_ops dw_mci_pmops; > + > enum dw_mci_state { > STATE_IDLE = 0, > STATE_SENDING_CMD, > -- > 2.37.2.352.g3c44437643 >