Re: [PATCH v7 8/8] mmc: sdhci-esdhc-imx: fix resume error handling
Dan Carpenter <[email protected]> Fri, 17 Jul 2026 14:52:58 +0300
| Newsgroups | org.kernel.vger.linux-mmc,dev.linux.lists.imx,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Oh, heh. I missed the entire point of the patch... It should have
just been:
ret = pm_runtime_force_resume(dev);
+ if (ret)
+ return ret;
Another way to silence the Sashiko warning about missing cleanup if
mmc_gpio_set_cd_wake() failed would be to add a comment.
ret = mmc_gpio_set_cd_wake(host->mmc, false);
if (ret) {
/* Just leak. It's fine. This path is impossible in 2026. */
return ret;
}
The other change was unrelated.
regards,
dan carpenter