RE: [PATCH v3 1/2] dt-bindings: mmc: cdns,sdhci: Add CQE support

Hi Conor,

Currently, there is no public domain information that confirms if the elba =
supports CQE.

In the last (v2) patch series, Krzysztof mentioned about why the Pensando E=
lba is NOT being modified/considered for the CQE.
The current implementation marks CQE as optional space and the related driv=
er can take the CQE or non-CQE path depending on whether the DT defines it.
Please refer to the cover letter for additional details on this.

Given the above information, can you please confirm if the next patch shoul=
d modify the elba or restrict the new reg entries to device compatibles?=20

Best Regards,
Rohan=20

-----Original Message-----
From: Conor Dooley <[email protected]>=20
Sent: Wednesday, July 22, 2026 10:07 PM
To: Rohan Santosh Joshi <[email protected]>
Cc: Ulf Hansson <[email protected]>; Rob Herring <[email protected]>; Krzysztof=
 Kozlowski <[email protected]>; Conor Dooley <[email protected]>; Masahi=
ro Yamada <[email protected]>; Adrian Hunter <adrian.hunter@int=
el.com>; [email protected]; [email protected]; linux-kerne=
[email protected]; Milind Parab <[email protected]>; Pawel Laszczak <pawel=
[email protected]>; Swapnil Kashinath Jakhade <[email protected]>; Manikanda=
n Karunakaran Pillai <[email protected]>; [email protected]
Subject: Re: [PATCH v3 1/2] dt-bindings: mmc: cdns,sdhci: Add CQE support

EXTERNAL MAIL


On Wed, Jul 22, 2026 at 04:18:37PM +0530, Rohan Joshi via B4 Relay wrote:
> From: Rohan Joshi <[email protected]>
>=20
> Cadence host controller can optionally support CQE.
> Add optional CQE register space to cdns sdhci bindings.
>=20
> Signed-off-by: Rohan Joshi <[email protected]>
> ---
>  .../devicetree/bindings/mmc/cdns,sdhci.yaml        | 28 ++++++++++++++++=
+++---
>  1 file changed, 25 insertions(+), 3 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Docu=
mentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> index 6c7317d13aa6..10bc9ac2073a 100644
> --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> @@ -22,7 +22,14 @@ properties:
> =20
>    reg:
>      minItems: 1
> -    maxItems: 2
> +    maxItems: 3
> +
> +  reg-names:
> +    minItems: 1
> +    items:
> +      - const: hc
> +      - enum: [bctl, cqhci]
> +      - const: cqhci
> =20
>    interrupts:
>      maxItems: 1
> @@ -131,13 +138,27 @@ allOf:
>      then:
>        properties:
>          reg:
> +          minItems: 2
>            items:
>              - description: Host controller registers
>              - description: Elba byte-lane enable register for writes
> +            - description: CQE (Command Queuing Engine) registers (optio=
nal)

I see no explanation in your commit message for why the elba is being
modified.

This new reg entry should be restricted to only the device-specific
compatibles that actually support it.

pw-bot: changes-requested

Thanks,
Conor.

> +        reg-names:
> +          minItems: 2
> +          items:
> +            - const: hc
> +            - const: bctl
> +            - const: cqhci
>      else:
>        properties:
>          reg:
> -          maxItems: 1
> +          items:
> +            - description: Host Controller registers
> +            - description: CQE (Command Queuing Engine) registers (optio=
nal)
> +        reg-names:
> +          items:
> +            - const: hc
> +            - const: cqhci
> =20
>  unevaluatedProperties: false
> =20
> @@ -145,7 +166,8 @@ examples:
>    - |
>      emmc: mmc@5a000000 {
>          compatible =3D "socionext,uniphier-sd4hc", "cdns,sd4hc";
> -        reg =3D <0x5a000000 0x400>;
> +        reg =3D <0x5a000000 0x400>, <0x5a000400 0x060>;
> +        reg-names =3D "hc", "cqhci";
>          interrupts =3D <0 78 4>;
>          clocks =3D <&clk 4>;
>          bus-width =3D <8>;
>=20
> --=20
> 2.43.0
>=20
>=20