Re: [PATCH v4 1/8] dt-bindings: mmc: add Cadence SD6HC binding

Krzysztof Kozlowski <[email protected]> Wed, 12 Aug 2026 12:29:14 +0200
Newsgroups org.kernel.vger.linux-mmc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <20260812-quick-determined-eagle-49eed9@quoll>
On Mon, Aug 10, 2026 at 12:00:15PM -0700, Tanmay Kathpalia wrote:
> +  cdns,iocell-input-delay-ps:
> +    description:
> +      Input delay across the IO cells, used for SD6HC PHY timing calculations.
> +    minimum: 0
> +    maximum: 20000
> +
> +  cdns,iocell-output-delay-ps:
> +    description:
> +      Output delay across the IO cells, used for SD6HC PHY timing calculations.
> +    minimum: 0
> +    maximum: 20000
> +
> +  cdns,delay-element-ps:
> +    description:
> +      DLL delay element size, used for SD6HC PHY timing calculations.
> +    minimum: 1
> +    maximum: 1000

I missed this in previous reviews:

It seems you have defaults for these three, so "default: xyz"

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof