Re: [PATCH 0/2] mmc: Make sure clk_init_data is fully initialized
Geert Uytterhoeven <[email protected]>
| Newsgroups | org.kernel.vger.linux-mmc,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-clk |
|---|---|
| Message-ID | <CAMuHMdXSwx36pDJ0kW=CvQztFx53OvcdfMTpv1h2H6J3z2+Wfg@mail.gmail.com> |
Hi Michal, On Fri, 21 Aug 2026 at 12:56, Michal Simek <[email protected]> wrote: > On 8/21/26 12:06, Geert Uytterhoeven wrote: > > The clk_init_data structure contains several mutually-exclusive members > > for different methods to specify the possible parents of a clock, > > prompting drivers to initialize only the members they need. However, > > not initializing all members may cause subtle issues, which are only > > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > > enabled. > > > > Hence this series aims to make sure all members are fully initialized, > > to avoid such bugs, and to prevent future breakage when converting > > drivers to a different method for specifying the parents. > > > > Part One[1] fixed all cases that I identified to be real bugs, in > > response to a crash I saw on BeagleBone Black. > > > > This series is the MMC subpart of Part Two, which fixes remaining cases > > that are currently harmless. These are still fragile, and may cause > > future breakage when converting drivers to a different method for > > specifying the parents. > > > > Thanks for your comments! > > > > [1] "[PATCH treewide 0/5] clk: Make sure clk_init_data is fully > > initialized (part 1)" > > https://lore.kernel.org/[email protected] > > > > Geert Uytterhoeven (2): > > mmc: meson-gx: FIXME: Make sure clk_init_data is fully initialized > > It looks like a broken series to me. Doh, I made a silly mistake while filling in the correct patch prefix... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds