Re: [PATCH v3] rust: add procedural macro for declaring configfs attributes
Malte Wechter <[email protected]>
| Newsgroups | org.kernel.vger.linux-modules,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <[email protected]> |
On 6/17/26 11:32 AM, Miguel Ojeda wrote: > On Wed, Jun 17, 2026 at 11:13 AM Malte Wechter <[email protected]> wrote: >> As of now doc strings are not generated for private items in the macros >> crate. I am moving the `parse_ordered_fields!` macro into >> macros/helpers.rs but this means the doc strings are not generated for >> the macro anymore. The `parse_ordered_fields!` macro is a larger helper >> function, and the doc strings are relevant and helpful for macro >> developers that wants to use it. > If it is private, then it is what it is, don't worry about it -- > developers can still read the source code. > > But, yes, having a render of the private items is something I have > wanted for a long time, but as a runtime toggle, so that it is easy to > go from one to the other (and without having to have 2 entire copies > of the docs). > > Please the entry "Private documentation (perhaps as an extension of > the private items/fields toggle)" I have at: > > https://github.com/Rust-for-Linux/linux/issues/350 > > Upstream `rustdoc` implemented an MVP of the idea via CSS/JS in this draft PR: > > https://github.com/rust-lang/rust/pull/141299 > > If you want to help on that, then you could try it and leave some > feedback there! :) > > Thanks! > > Cheers, > Miguel I will leave it as it is then. I will try and look at it if time permits :) Best regards, Malte