Re: [PATCH v2 3/7] rust: doctest: add LocalModule fallback for #[vtable] ThisModule
Alvin Sun <[email protected]>
| Newsgroups | org.kernel.vger.linux-modules,dev.linux.lists.driver-core,dev.linux.lists.nova-gpu,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-block,org.kernel.vger.linux-kselftest,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <[email protected]> |
On 6/18/26 20:13, Andreas Hindborg wrote: > Alvin Sun <[email protected]> writes: > >> Add a `LocalModule` struct with a null-pointer `ModuleMetadata` impl >> in the doctest harness, so that `crate::LocalModule` (auto-inserted >> by `#[vtable]`) resolves correctly when there is no `module!` macro. >> >> Signed-off-by: Alvin Sun <[email protected]> > Reviewed-by: Andreas Hindborg <[email protected]> > > Does this need to be ordered before the vtable auto insert in the patch series? Yes, you're right — this patch would be better placed before the vtable auto-insert patch to avoid a temporary state where the doctest harness doesn't provide the LocalModule fallback that #[vtable] expects. Thanks for the suggestions from you and Gary. v3 has been sent to the list: https://lore.kernel.org/rust-for-linux/[email protected] Best regards, Alvin Sun > > Best regards, > Andreas Hindborg > >