Re: [PATCH 3/4] tpm_crb_ffa: Include linux/slab.h for kzalloc_obj() and kfree()

[email protected] Tue, 07 Jul 2026 15:43:37 +0000
Newsgroups org.kernel.vger.linux-modules,org.kernel.vger.kvm,org.kernel.vger.linux-s390
Message-ID <[email protected]>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message incorrectly claims that the file uses `kzalloc_obj()` instead of `kzalloc()`.
--

--- Patch [3]: [PATCH 3/4] tpm_crb_ffa: Include linux/slab.h for kzalloc_obj() and kfree() ---
commit a56e4cf89267d12126bd70f7981a05c846959016
Author: Petr Pavlu <[email protected]>

tpm_crb_ffa: Include linux/slab.h for kzalloc_obj() and kfree()

This commit adds the missing linux/slab.h inclusion to tpm_crb_ffa.c.
It removes the reliance on indirect inclusion through linux/module.h.
This prepares for the eventual removal of linux/elf.h from linux/module.h.

> tpm_crb_ffa: Include linux/slab.h for kzalloc_obj() and kfree()

[Severity: Low]
This isn't a bug, but there appears to be a typo in the commit subject.
Did you mean kzalloc() instead of kzalloc_obj()? Looking at
tpm_crb_ffa_probe() in the driver, it correctly calls kzalloc().

> The drivers/char/tpm/tpm_crb_ffa.c file uses kzalloc_obj() and kfree(),

[Severity: Low]
This isn't a bug, but the same typo is also present here in the commit
description.

-- 
Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3