Re: [PATCH] ARM: unwind: modules: Fix the mismatch between .ARM.exidx* and .text

[email protected]
Newsgroups org.kernel.vger.linux-modules
Message-ID <[email protected]>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the wildcard pattern `[0-9a-z-A-Z_]*` introduces an unintended literal hyphen and diverges from the `.text` pattern syntax.
--

--- Patch [1]: [PATCH] ARM: unwind: modules: Fix the mismatch between .ARM.exidx* and .text ---
commit 77bfa32ad8c348a1008e578b132ff69e6108ddd2
Author: Xie Yuanbin <[email protected]>

ARM: unwind: modules: Fix the mismatch between .ARM.exidx* and .text

This commit modifies the module linker script for ARM to merge
.ARM.extab.text.* and .ARM.exidx.text.* sections. It addresses a stack
unwinding failure caused by newer compilers splitting sections.

> diff --git a/scripts/module.lds.S b/scripts/module.lds.S
> index d0f2004289576..0ccf0c205d005 100644
> --- a/scripts/module.lds.S
> +++ b/scripts/module.lds.S
> @@ -39,6 +39,10 @@ SECTIONS {
>  	.text			0 : {
>  		*(.text .text.[0-9a-zA-Z_]*)
>  	}
> +#if defined(CONFIG_ARM) && defined(CONFIG_ARM_UNWIND)
> +	.ARM.extab : {*(.ARM.extab .ARM.extab.text.[0-9a-z-A-Z_]*) }
> +	.ARM.exidx : {*(.ARM.exidx .ARM.exidx.text.[0-9a-z-A-Z_]*) }

[Severity: Low]
This isn't a bug, but there appears to be an extra hyphen in the wildcard
pattern between z and A. Could this be corrected to match the [0-9a-zA-Z_]*
pattern used in the .text section just above?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.