Re: [PATCH] rust: macros: Allow omitting trailing commas in module!

Miguel Ojeda <[email protected]>
Newsgroups org.kernel.vger.linux-modules,org.kernel.vger.linux-kernel,org.kernel.vger.rust-for-linux
Message-ID <CANiq72kXkY_CtxxedtpV1DykxGZ-SDwAYzAo6d_iDaVs7DthtA@mail.gmail.com>
On Thu, Aug 6, 2026 at 1:54 PM Gary Guo <[email protected]> wrote:
>
> Hmm, I am not sure if we really want this.
>
> `module!` invocation usually spans multiple lines so the formatting rules would
> always prefer adding trailing comma for this case.
>
> Allowing omitting sounds like encouraging bad practice.

Yeah, it also means inconsistency can be introduced for little gain.

Cheers,
Miguel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.