Re: [PATCH 1/1] ipc/mqueue.c: Drag unneeded code out of locks
Steven Stewart-Gallus <[email protected]> Sat, 15 Nov 2014 04:42:34 +0000 (GMT)
| Newsgroups | org.kernel.vger.linux-newbie,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hello, thank you for the criticism. > It's probably better to do this as three or four separate patches. Really? Alright if you insist I'll do the next version as multiple patches. > Well yes, that's what EMFILE means but "too_many_open_files" doesn't > make sense in this context! Fair enough, I'll rename it in the next version. > Thatsabug. It only requires CAP_SYS_RESOURCE if we're trying with > queues_count >= queues_max. Right, that was dumb of me. > This test isn't really needed. I don't follow. If the queue creation is not rejected then the resource user has to be accounted for right? And we can't add the resource to accounting if it is not created right? Thank you, Steven Stewart-Gallus