newbie: submitting a driver patch the first time

Hello everyone,

I would like to integrate some of our company drivers into the Vanilla Linux kernel, but I have never done this before.
Some esteemed colleagues did this a few years earlier, but unfortunately they are no longer with the company and we lost all information on how to do it.

We want to set up a process to keep the knowledge, but we have to start over. I am the chosen one who shall do this.

So I read a lot of guidelines and kernel documentation and create a first patch-set of one driver to be submitted. Before going to the actual mailing lists (scripts/get_maintainer.pl), I would like to send this patch-set to the linux-newbie list for hopefully some constructive comments.


The driver is a BMC driver that supports the company's generic BMC called "14Y007", which is assembled on many of our hardware components. The BMC is connected via I2C. The driver is a further development of the menf21bmc driver, which is already in the kernel.
The driver is not yet finished and can be adjusted at anytime.

First question: Does it make sense to publish the driver at linux-newbie for a review before doing it on the actual mailing lists?

Regards,
Andreas

-- 
Andreas Geissler - Software Engineer

MEN Mikro Elektronik GmbH
Neuwieder Straße 1-7 90411 Nürnberg
Geschäftsführer: Dr. Michael Goldbach - Matthias Kamolz - Yilmaz Kocak - Handelsregister AG Nürnberg HRB 5540