Re: [PATCH -next] rust: fwctl: replace `__pinned_init` with `raw_try_init`

Jason Gunthorpe <[email protected]>
Newsgroups org.kernel.vger.linux-next,org.kernel.vger.rust-for-linux
Message-ID <[email protected]>
On Tue, Aug 18, 2026 at 12:53:50PM +0200, Miguel Ojeda wrote:
> Commit
> 
>   ea7da3116015 ("rust: treewide: replace `__pinned_init` with `raw_[try_]init`")
> 
> from the pin-init tree replaced the method before removing it, but commit
> 
>   e052daab94ee ("rust: introduce abstractions for fwctl")
> 
> from the fwctl tree added a new use.
> 
> Thus replace that one as well to fix this error in next-20260817:
> 
>     error[E0599]: no method named `__pinned_init` found for associated type `impl pin_init::PinInit<T, error::Error>` in the current scope
>        --> rust/kernel/fwctl.rs:465:49
>         |
>     465 |                 match T::open(device, reg_data).__pinned_init(uctx_ptr) {
>         |                                                 ^^^^^^^^^^^^^ method not found in `impl pin_init::PinInit<T, error::Error>`

If you delete functions like this then you break everyone elses branches :|

I can't use this patch:

465 |              match pin_init::raw_try_init(uctx_ptr, T::open(device, reg_data)) {
    |                              ^^^^^^^^^^^^ not found in `pin_init`


Linus will have to fix this as a merge conflict.

Jason
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.