Re: [PATCH 2/2] nfsd: fix nfserr type in nfsd_lookup_dentry()
"Chuck Lever" <[email protected]> Mon, 03 Aug 2026 11:16:48 -0400
| Newsgroups | org.kernel.vger.linux-nfs,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Aug 3, 2026, at 10:49 AM, Jeff Layton wrote:
> Both nfsd_lookup_dentry() and nfsd_cross_mnt() return __be32.
>
> Fixes: cf78c5a7d742 ("nfsd: move check_nfsd_access() call into
> nfsd_cross_mnt()")
> Signed-off-by: Jeff Layton <[email protected]>
> ---
> fs/nfsd/vfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index edb08c006a23..807e09521e0c 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -287,7 +287,7 @@ nfsd_lookup_dentry(struct svc_rqst *rqstp, struct
> svc_fh *fhp,
> if (IS_ERR(dentry))
> goto out_nfserr;
> if (nfsd_mountpoint(dentry, exp)) {
> - int nfserr = nfsd_cross_mnt(rqstp, &dentry, &exp);
> + __be32 nfserr = nfsd_cross_mnt(rqstp, &dentry, &exp);
>
> if (nfserr) {
> dput(dentry);
>
> --
> 2.55.0
Folded into "nfsd: move check_nfsd_access() call into nfsd_cross_mnt()".
--
Chuck Lever