Re: [PATCH 2/2] NFSD: Update the atime for iterator READs
Christoph Hellwig <[email protected]>
| Newsgroups | org.kernel.vger.linux-nfs,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Aug 19, 2026 at 03:57:15AM +0500, Ameer Hamza wrote: > A READ served by nfsd_iter_read() or nfsd_direct_read() leaves the > atime update to the filesystem's ->read_iter, and not every > implementation does it: fuse_dax_read_iter() carries a TODO for > it, and kernfs_fop_read_iter() does not touch the atime at all. On > a fuse DAX export, READs never advance the atime, no matter how > often clients read the file. Spliced READs are not affected, since > splice_direct_to_actor() ends with file_accessed(). nfsd serves > whatever filesystem is exported, so it cannot rely on every > ->read_iter keeping the convention. Code outside of file systems and library code has absolutely no business ever calling file_accessed. And please stop this LLM garbage. Your patches seem to have a pattern of finding some unusual corner case that is broken in a file system and than work around it in core code. That's not how it works.