Re: [PATCH 2/2] NFSD: Update the atime for iterator READs
"Chuck Lever" <[email protected]>
| Newsgroups | org.kernel.vger.linux-nfs,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Aug 19, 2026, at 1:58 AM, Christoph Hellwig wrote: > Code outside of file systems and library code has absolutely no > business ever calling file_accessed. Every call site in the kernel is a filesystem, so indeed, NFSD would have been the first call site outside a filesystem. I misread the FUSE code: I see now that FUSE does not maintain atime in the kernel. file_accessed() from NFSD would have stamped a kernel- side atime on an inode whose atime the user space filesystem manages. I assumed FamFS would hit this very issue, but maybe it does not. The TODO in fuse_dax_read_iter() is a bit confusing. Implementing that should be a one-liner, or it should be replaced with a comment that explains why that callback is missing an explicit atime update. So we can drop 2/2. Sorry for the noise. -- Chuck Lever