Re: [syzbot] [nilfs?] WARNING in nilfs_ioctl_prepare_clean_segments
Junjie Cao <[email protected]> Tue, 24 Mar 2026 18:45:59 +0800
| Newsgroups | org.kernel.vger.linux-nilfs,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
Please test the following patch. From: Junjie Cao <[email protected]> Date: Thu, 19 Mar 2026 00:00:00 +0800 Subject: [PATCH] nilfs2: skip blocks with no bmap entry in nilfs_ioctl_mark_blocks_dirty() In nilfs_ioctl_mark_blocks_dirty(), called during garbage collection, nilfs_bmap_lookup_at_level() may return -ENOENT when a block no longer exists in the DAT bmap. In that case the code sets bd_blocknr to 0 but falls through to the liveness check that compares bd_blocknr against bd_oblocknr. If bd_oblocknr also happens to be 0, the descriptor is incorrectly treated as live and the code attempts to get or mark the non-existent block, triggering a WARN_ON. Fix this by adding a continue statement so that a block descriptor is immediately skipped when its bmap lookup returns -ENOENT, since there is no block in the DAT to mark dirty. Fixes: 7942b919f732 ("nilfs2: ioctl operations") Reported-by: [email protected] Closes: https://syzkaller.appspot.com/bug?extid=466a45fcfb0562f5b9a0 Cc: [email protected] Signed-off-by: Junjie Cao <[email protected]> --- fs/nilfs2/ioctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c index 1bfe8a2..d71a0a5 100644 --- a/fs/nilfs2/ioctl.c +++ b/fs/nilfs2/ioctl.c @@ -744,6 +744,7 @@ static int nilfs_ioctl_mark_blocks_dirty(struct the_nilfs *nilfs, if (ret < 0) { if (ret != -ENOENT) return ret; bdescs[i].bd_blocknr = 0; + continue; } if (bdescs[i].bd_blocknr != bdescs[i].bd_oblocknr) /* skip dead block */ -- 2.43.0