Re: [PATCH v2 29/34] nilfs2: Convert nilfs_mdt_submit_block to bh_submit()

On Thu 28-05-26 18:31:42, Matthew Wilcox (Oracle) wrote:
> Avoid an extra indirect function call and changing the buffer refcount
> by using bh_submit() instead of submit_bh().
> 
> Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
> Reviewed-by: Viacheslav Dubeyko <[email protected]>
> Acked-by: Ryusuke Konishi <[email protected]>
> Cc: [email protected]

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

								Honza

> ---
>  fs/nilfs2/mdt.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/nilfs2/mdt.c b/fs/nilfs2/mdt.c
> index 09adb40c65e5..2a435349fd21 100644
> --- a/fs/nilfs2/mdt.c
> +++ b/fs/nilfs2/mdt.c
> @@ -148,9 +148,7 @@ nilfs_mdt_submit_block(struct inode *inode, unsigned long blkoff, blk_opf_t opf,
>  	}
>  	map_bh(bh, inode->i_sb, (sector_t)blknum);
>  
> -	bh->b_end_io = end_buffer_read_sync;
> -	get_bh(bh);
> -	submit_bh(opf, bh);
> +	bh_submit(bh, opf, bh_end_read);
>  	ret = 0;
>  
>  	trace_nilfs2_mdt_submit_block(inode, inode->i_ino, blkoff,
> -- 
> 2.47.3
> 
-- 
Jan Kara <[email protected]>
SUSE Labs, CR