Re: [PATCH 8/8] numa: update Documentation/vm/numa, add memoryless node info

On Thu, 15 Apr 2010 13:30:42 -0400
Lee Schermerhorn <[email protected]> wrote:

> Against:  2.6.34-rc3-mmotm-100405-1609
> 
> Kamezawa Hiroyuki requested documentation for the numa_mem_id()
> and slab related changes.  He suggested Documentation/vm/numa for
> this documentation.  Looking at this file, it seems to me to be
> hopelessly out of date relative to current Linux NUMA support.
> At the risk of going down a rathole, I have made an attempt to
> rewrite the doc at a slightly higher level [I think] and provide
> pointers to other in-tree documents and out-of-tree man pages that
> cover the details.
> 
> Let the games begin.
> 
> Signed-off-by: Lee Schermerhorn <[email protected]>
> 

Thank you, seems very nice and covers almost all range we have to explain
to new comers. 
My eye can't check details enough but...;)

Reviewed-by: KAMEZAWA Hiroyuki <[email protected]>

I think this patch itself is very good.

Being more greedy...

Hmm, from user's view, I feel quick guide of

/sys/devices/system/node/
and 
 /sys/devices/system/node/node0/numastat 
can be added somewhere. (Documentation/numastat.txt is not under /vm :( )

And one more important? thing.

[kamezawa@firextal Documentation]$ cat /sys/bus/pci/devices/0000\:00\:01.0/numa_node
-1

PCI device (and other??) has numa_node_id in it, if it has locality information.
I hear some guy had to be aware locality of NIC to do high-throuput network
transaction. Then, "how to get device's locality via sysfs" is worth to be
written.

And mentioning what "nid = -1" means may help new comer.

Thanks,
-Kame