Re: [PATCH 3/7] numa-x86_64-use-generic-percpu-var-numa_node_id-implementation-fix1

On Mon, 03 May 2010 11:05:18 -0400
Lee Schermerhorn <[email protected]> wrote:

> Incremental patch 1 to
> numa-x86_64-use-generic-percpu-var-numa_node_id-implementation.patch
> in 28apr10 mmotm.
> 
> Use generic percpu numa_node variable only for x86_64.
> 
> x86_32 will require separate support.  Not sure it's worth it.
> 
> Signed-off-by: Lee Schermerhorn <[email protected]>
> 
>  arch/x86/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.34-rc5-mmotm-100428-1653/arch/x86/Kconfig
> ===================================================================
> --- linux-2.6.34-rc5-mmotm-100428-1653.orig/arch/x86/Kconfig
> +++ linux-2.6.34-rc5-mmotm-100428-1653/arch/x86/Kconfig
> @@ -1720,7 +1720,7 @@ config HAVE_ARCH_EARLY_PFN_TO_NID
>  	depends on NUMA
>  
>  config USE_PERCPU_NUMA_NODE_ID
> -	def_bool y
> +	def_bool X86_64
>  	depends on NUMA
>  
>  menu "Power management and ACPI options"

i386 allmodconfig:

In file included from include/linux/gfp.h:7,
                 from include/linux/kmod.h:22,
                 from include/linux/module.h:13,
                 from include/linux/crypto.h:21,
                 from arch/x86/kernel/asm-offsets_32.c:7,
                 from arch/x86/kernel/asm-offsets.c:2:
include/linux/topology.h: In function 'numa_node_id':
include/linux/topology.h:248: error: implicit declaration of function 'cpu_to_node'

this patchset has been quite a PITA.  What happened?