Re: [PATCH] Do not use cpu_to_node() to find an offlined cpu's node.
Peter Zijlstra <[email protected]> Tue, 09 Oct 2012 12:57:36 +0200
| Newsgroups | org.kernel.vger.linux-numa,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <1349780256.7880.12.camel@twins> |
On Mon, 2012-10-08 at 10:59 +0800, Tang Chen wrote: > If a cpu is offline, its nid will be set to -1, and cpu_to_node(cpu) will > return -1. As a result, cpumask_of_node(nid) will return NULL. In this case, > find_next_bit() in for_each_cpu will get a NULL pointer and cause panic. Hurm,. this is new, right? Who is changing all these semantics without auditing the tree and informing all affected people?