Re: [PATCH] fix numactl test

"Rick \"Zero_Chaos\" Farina" <[email protected]> Tue, 05 May 2015 00:32:39 -0400
Newsgroups org.kernel.vger.linux-numa
Message-ID <[email protected]>
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--PGn0HpcJhWv1FpKvB4geHXeRR7hWkpDsl
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 05/04/2015 04:29 PM, Filipe Brandenburger wrote:
> Hi Rick,
>=20
> On Sun, May 3, 2015 at 7:35 PM, Rick "Zero_Chaos" Farina
> <[email protected]> wrote:
>> I apologize if this is already handled, however, a quick google search=

>> didn't help me find any version control systems so I'm submitting here=
=2E
>=20
> The numactl sources have been recently uploaded to this git repository:=

> https://github.com/numactl/numactl
>=20
>> In Gentoo we got a bug, where numactl fails tests if it isn't already
>> installed:
>>
>> https://bugs.gentoo.org/show_bug.cgi?id=3D502586
>>
>> ./bind_range: line 92: numactl: command not found
>> ./bind_range: line 93: numactl: command not found
>>
>> The origin is fairly trivial, it appears that on the noted lines it's
>> calling "numactl" instead of "../numactl" like it should.  Which means=

>> it will try to use an installed numactl (possibly older) and fail if i=
t
>> isn't installed at all.
>=20
> Yes, this was fixed in this commit:
> https://github.com/numactl/numactl/commit/25c052affbbcd2df0f67376d18d3a=
c4028326175
>=20
> It's more general, as it adds the build directory to $PATH and it also
> works when an out-of-tree build is used.
>=20
> May I suggest that you upgrade to the latest 2.0.10 which does contain =
this fix?

2.0.10 has a bug related to gentoo which I haven't figured out yet
(doesn't appear to be upstream related afaict so far so don't worry
about it) so when I saw the same call to numactl in both I assumed the
bug was still there.  Glad it's fixed, thanks for the work :-)

-Zero_Chaos


--PGn0HpcJhWv1FpKvB4geHXeRR7hWkpDsl
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVSEfqAAoJEKXdFCfdEflKXK0QALsyv1CHMutrklN6Pavb7IYn
Wwc5RJ6zLjckROLCyD1jwTAL41QeMtyY07x1z8zPUjuJ+78zo+BAF1ISpuSlXBcW
Ws4JA0FUyl7J0FTrSB0wx1p5v3Ku92KyaP0lUxULj1nzyHcUA3BxcT6l5hiVSh40
WH5JOUl8npwLmB6etsmeZJl1XWk5UgPU1Z6ViTy6CJjcbMjm4pbU3B7cui/7TJSG
NnJ3Tc2NJhsDxtBNo4BTUC9YcvLzHO+aSwgbsLiNyNrJKKEhZiNcDb1XJ4ODGZYv
rRrrL+jxBwJWzEe4fE3nt5PfC07woBPSJI0DKstwZpJAN3XRAGFe9lNL2dKxtva0
U8XsKLVw48qInzBRMJsX9b4/CrNC9i+o/aFfQqecGcbife4a+l59iTZ52LOFTDAw
0e1lFrlBYuEAZkhBKXxBCjcYL9sJZfPxJd2ihJb0j0HKfjMbOCKvP423JniYOW5+
ubKUKTG+zGDLYdJUCpUty8ffLAkLQElxc2B3QfBiNjEIfnh79UgYjJ70qOe8PgiN
7axNOQggULXuZKZziRJ3l4zfAa3jV/TPFfjy8c6U/s/q99U+a3VM8pRXKoxou+Nf
6u/Up0XBSbvLkABL7MmlbvJEroSX0neRXJWLbIO7Slh7DRvNd63Y/eA9H1dURfOk
iHsPV7IQhp3NXluBZ/6Q
=RoBj
-----END PGP SIGNATURE-----

--PGn0HpcJhWv1FpKvB4geHXeRR7hWkpDsl--