Re: [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes

David Miller <[email protected]> Tue, 21 Jul 2015 22:26:48 -0700 (PDT)

Newsgroups	org.kernel.vger.linux-numa,org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.ozlabs.lists.linuxppc-dev
Message-ID	<[email protected]>

From: Chris J Arges <[email protected]>
Date: Tue, 21 Jul 2015 12:36:33 -0500

> Some architectures like POWER can have a NUMA node_possible_map that
> contains sparse entries. This causes memory corruption with openvswitch
> since it allocates flow_cache with a multiple of num_possible_nodes() and
> assumes the node variable returned by for_each_node will index into
> flow->stats[node].
> 
> Use nr_node_ids to allocate a maximal sparse array instead of
> num_possible_nodes().
> 
> The crash was noticed after 3af229f2 was applied as it changed the
> node_possible_map to match node_online_map on boot.
> Fixes: 3af229f2071f5b5cb31664be6109561fbe19c861
> 
> Signed-off-by: Chris J Arges <[email protected]>

Applied, thanks.