Re: [PATCH v3 4/7] PCI: dwc: Use common pci_host_common_link_train_delay() helper
Krzysztof Wilczyński <[email protected]>
| Newsgroups | org.kernel.vger.linux-omap,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci,org.kernel.vger.linux-renesas-soc |
|---|---|
| Message-ID | <20260512071328.GA3606279@rocinante> |
Hello, > > > - /* > > > - * As per PCIe r6.0, sec 6.6.1, a Downstream Port that supports Link > > > - * speeds greater than 5.0 GT/s, software must wait a minimum of 100 ms > > > - * after Link training completes before sending a Configuration Request. > > > - */ > > > - if (pci->max_link_speed > 2) > > > - msleep(PCIE_RESET_CONFIG_WAIT_MS); > > > + pci_host_common_link_train_delay(pci->max_link_speed); > > > > This comment could move to the helper you added. > > Hi Krzysztof, > > Will add. No need. Per Mani's feedback about macro being well documented. Thank you nonetheless! Krzysztof