Re: [PATCH] memory: omap-gpmc: Silence clang kerneldoc warnings
Nathan Chancellor <[email protected]>
| Newsgroups | org.kernel.vger.linux-omap,dev.linux.lists.llvm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260519161402.GA3527449@ax162> |
On Tue, May 19, 2026 at 03:25:49PM +0200, Krzysztof Kozlowski wrote: > Recent LLVM prints kerneldoc W=1 warnings, even though a correct > kerneldoc is there: I don't see how LLVM is relevant here, a GCC build would show the same warnings since they come from kernel-doc, not the compiler. > Warning: drivers/memory/omap-gpmc.c:441 Excess function parameter 'cs' description in 'get_gpmc_timing_reg' > > Drop additional inline comments for arguments to fix that. They are > anyway not that useful. > > Signed-off-by: Krzysztof Kozlowski <[email protected]> > --- > drivers/memory/omap-gpmc.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c > index d9e13c1f9b13..958d2b0ea54a 100644 > --- a/drivers/memory/omap-gpmc.c > +++ b/drivers/memory/omap-gpmc.c > @@ -432,13 +432,9 @@ static unsigned int gpmc_clk_ticks_to_ns(unsigned int ticks, int cs, > * > */ > static int get_gpmc_timing_reg( > - /* timing specifiers */ > int cs, int reg, int st_bit, int end_bit, int max, > const char *name, const enum gpmc_clk_domain cd, > - /* value transform */ > - int shift, > - /* format specifiers */ > - bool raw, bool noval) > + int shift, bool raw, bool noval) > { > u32 l; > int nr_bits; > -- > 2.51.0 > -- Cheers, Nathan