Re: [RFC PATCH] drm: omapdrm: dsi: add refsel also for omap4

On Wed, 13 Sep 2023 15:11:08 +0300
Tomi Valkeinen <[email protected]> wrote:

> On 13/09/2023 09:59, Andreas Kemnade wrote:
> > Some 3.0 source has it set behind a if (omap4).
> > Maybe it is helpful maybe not, at least in the omap4460
> > trm these bits are marked as reserved.
> > But maybe some dsi video mode panel starts magically working.  
> 
> Sorry, what does this mean? That this fixes something, or you are just 
> guessing?
> 
> I'm somewhat sure that the upstream driver used to work on omap4 sdp, 
> which has two DSI panels. But I can't even remember what omap4 version 
> it had.
> 

this thing is definitively not needed. I have dropped this patch from
my tree.

Regards,
Andreas

>   Tomi
> 
> > Signed-off-by: Andreas Kemnade <[email protected]>
> > ---
> >   drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> > index 60189a23506a1..e2f576cd9f63c 100644
> > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> > @@ -4505,7 +4505,7 @@ static const struct dss_pll_hw dss_omap4_dsi_pll_hw = {
> >   	.has_stopmode = true,
> >   	.has_freqsel = false,
> >   	.has_selfreqdco = false,
> > -	.has_refsel = false,
> > +	.has_refsel = true,
> >   };
> >   
> >   static const struct dss_pll_hw dss_omap5_dsi_pll_hw = {  
> 
>