Re: [PATCH 2/4] ASoC: ti: omap3pandora: remove

On Wed, 3 Jun 2026 18:26:52 +0200
"H. Nikolaus Schaller" <[email protected]> wrote:

> > Am 03.06.2026 um 16:00 schrieb Andreas Kemnade <[email protected]>:
> > 
> > On Wed, 03 Jun 2026 14:09:23 +0200
> > Sascha Hauer <[email protected]> wrote:
> >   
> >> The omap3pandora driver entirely depends on machine_is_omap3_pandora().
> >> Pandora has been converted to device tree:
> >> 
> >> 7fcf7e061edd3 ("ARM: OMAP2+: Remove legacy booting support for Pandora")  
> 
> 11 years ago :)
> 
> >> 
> >> Since then machine_is_omap3_pandora() always expands to 0. Remove the
> >> long unused driver.
> >> 
> >> Signed-off-by: Sascha Hauer <[email protected]>
> >> ---
> >> sound/soc/ti/Kconfig        |   9 --
> >> sound/soc/ti/Makefile       |   2 -
> >> sound/soc/ti/omap3pandora.c | 290 --------------------------------------------
> >> 3 files changed, 301 deletions(-)
> >>   
> > On the first glance, this looks ok... but
> > I know there was work undergone in converting this to devicetree but it
> > appeared not upstream.  
> 
> Thanks for spotting (before we would have been surprised).
> 
> > 
> > So
> > Grond, hns: What are your plans in this? You are effectively maintaining this
> > out-of-mainline. What are your upstreaming plans?
> > 
> > Do we need this kind of glue anyway? Or can we use some of the
> > audio-graph-card stuff instead to wire up things?  
> 
> Tony also had mentioned something like this in [1].
> 
> I have checked the status of the LetuxOS kernel [2]:
> 
> There are patches for the device tree (a simple one without audio graphs) and patches
> for sound/soc/ti/omap3pandora.c and adding a TI PCM1773 driver.

Just a quick glance:

audio-graph-card2 seems to accept amplifiers. 
So probably it boils down to just remove this and
add a compatible to ti,pcm1754.yaml and a devicetree patch to use
audio-grapch-card2.

and maybe the regen stuff.

Regards,
Andreas