[PATCH] fix: net: ti: cpts_of_mux_clk_setup: fix device_node reference leak on success path
WenTao Liang <[email protected]> Fri, 26 Jun 2026 23:31:48 +0800
| Newsgroups | org.kernel.vger.linux-omap,org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
of_get_child_by_name acquires a device_node reference for refclk_np, and of_clk_add_hw_provider additionally takes an extra reference internally. On the success path, the function returns 0 without calling of_node_put(refclk_np), leaking the initial reference. Add of_node_put(refclk_np) before returning success to properly release the acquired reference. Cc: [email protected] Fixes: a3047a81ba13 ("net: ethernet: ti: cpts: add support for ext rftclk selection") Signed-off-by: WenTao Liang <[email protected]> --- drivers/net/ethernet/ti/cpts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c index 2ba4c8795d60..d6e6d074747e 100644 --- a/drivers/net/ethernet/ti/cpts.c +++ b/drivers/net/ethernet/ti/cpts.c @@ -714,7 +714,8 @@ static int cpts_of_mux_clk_setup(struct cpts *cpts, struct device_node *node) goto mux_fail; } - return ret; + of_node_put(refclk_np); + return 0; mux_fail: of_node_put(refclk_np); -- 2.39.5 (Apple Git-154)