Re: [PATCH v3 1/4] dt-bindings: phy: motorola,cpcap-usb: add chrg_det interrupt

On 06/07/2026 22:25, Ivaylo Dimitrov wrote:
> 
> Hi,
> 
> On 6.07.26 г. 20:14 ч., Conor Dooley wrote:
>> On Sun, Jul 05, 2026 at 01:11:02PM +0300, Ivaylo Dimitrov wrote:
>>> The CPCAP USB PHY driver uses the CPCAP charger detection interrupt
>>> for DCP detection.
>>
>> This is not currently true, the driver does not look for this interrupt
>> at the time of this patch.
>>
> 
> Right, this is bad wording caused by the fact that initially the driver
> patch came before the binding patch.
> 
>>> Update the binding and example DTS to use the corresponding
>>> "chrg_det" interrupt name.
>>
>> Sounds to me like this new interrupt is optional, since until now it has
>> not been needed? The patch however makes it mandatory. I think your
>> driver patch also makes it mandatory, which will break older
>> devicetrees.
>>
> 
> Oh, it is indeed not needed for proper DCP/SDP detection, after some
> experiments I was able to teach the driver to do proper detection by
> using current interrupts only.
> 
>> What makes this ABI break okay?
>>
> 
> Will send new series with schema/DT patches dropped.

I think the devicetree patches are fine, provided you add
a minItems of N-1 so that the new interrupt is optional.
Dropping them would mean that the documentation for this device
remains incomplete since that interrupt does exist.

Cheers,
Conor.