Re: [PATCH 0/6] tty: serial: propagate errors from uart_ops.pm callback
Andy Shevchenko <[email protected]> Thu, 9 Jul 2026 13:16:08 +0300
| Newsgroups | org.kernel.vger.linux-omap,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-samsung-soc,org.kernel.vger.linux-serial |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Thu, Jul 09, 2026 at 02:22:17PM +0530, Praveen Talari wrote: > On 09-07-2026 12:23, Jiri Slaby wrote: > > On 09. 07. 26, 8:25, Praveen Talari wrote: ... > > OK, now I miss the rationale behind the patchset. Neither there is a > > possible code path to actually test this? > The rationale is that qcom_geni_serial_pm() calls > pm_runtime_resume_and_get() which can fail, but its return value is > currently discarded because the callback is void. So, you take the solution from a wrong end. Just get rid of .pm() in your driver. With that, problem solved. Really, this series is a road to even more broken PM solutions. -- With Best Regards, Andy Shevchenko