Re: [PATCH] counter: Remove redundant dev_err()/dev_err_probe()
PanChuang <[email protected]> Wed, 15 Jul 2026 10:26:29 +0800
| Newsgroups | org.kernel.vger.linux-omap,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, 13 Jul 2026 22:12:00 +0800, Joshua Crofts wrote: > On Mon, 13 Jul 2026 21:10:04 +0800 > Pan Chuang <[email protected]> wrote: > >> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in >> devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq() >> automatically log detailed error messages on failure. Remove the >> now-redundant driver-specific dev_err() and dev_err_probe() calls. >> >> Signed-off-by: Pan Chuang <[email protected]> >> --- > I think you can drop the commit hash and title from the message. > Otherwise LGTM. > > Reviewed-by: Joshua Crofts <[email protected]> Will drop the commit hash/title in v2. Thanks for the review! Best regards, PanChuang