Re: [PATCH v2 07/10] ASoC: ti: omap-hdmi: Use dev_err_probe() for error handling
Cezary Rojewski <[email protected]> Thu, 16 Jul 2026 11:28:57 +0200
| Newsgroups | org.kernel.vger.linux-omap,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <[email protected]> |
On 7/16/2026 11:08 AM, [email protected] wrote: > From: bui duc phuc <[email protected]> > > Replace dev_err() with dev_err_probe() when reporting > devm_snd_soc_register_card() failures. This suppresses > unnecessary log messages for deferred probe errors. > > Signed-off-by: bui duc phuc <[email protected]> > --- > sound/soc/ti/omap-hdmi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/ti/omap-hdmi.c b/sound/soc/ti/omap-hdmi.c > index e60f5b483fc5..72114965c37d 100644 > --- a/sound/soc/ti/omap-hdmi.c > +++ b/sound/soc/ti/omap-hdmi.c > @@ -375,10 +375,8 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev) > card->dev = dev; > > ret = devm_snd_soc_register_card(dev, card); > - if (ret) { > - dev_err(dev, "snd_soc_register_card failed (%d)\n", ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, "snd_soc_register_card failed\n"); Some patches have '()' some do not. I'd expect all the patches updated as per Christophe's review. > > ad->card = card; > snd_soc_card_set_drvdata(card, ad);