[PATCH v2 2/2] ARM: dts: ti: omap: Disable keypad and enable it on the boards that use it
Eduard Bostina <[email protected]> Sun, 19 Jul 2026 13:37:30 +0000
| Newsgroups | org.kernel.vger.linux-omap,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
The keypad node in omap4-l4.dtsi and omap5-l4.dtsi lacks the matrix keymap, which is board specific. The binding requires the matrix properties, so the incomplete template nodes fail dtbs_check. Mark the keypad disabled in the SoC files and enable it on the boards that actually complete the node with a keymap. Signed-off-by: Eduard Bostina <[email protected]> --- arch/arm/boot/dts/ti/omap/motorola-mapphone-mz607-mz617.dtsi | 2 ++ arch/arm/boot/dts/ti/omap/omap4-droid-bionic-xt875.dts | 2 ++ arch/arm/boot/dts/ti/omap/omap4-droid4-xt894.dts | 2 ++ arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 2 ++ arch/arm/boot/dts/ti/omap/omap4-l4.dtsi | 1 + arch/arm/boot/dts/ti/omap/omap4-sdp.dts | 2 ++ arch/arm/boot/dts/ti/omap/omap5-l4.dtsi | 1 + 7 files changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/ti/omap/motorola-mapphone-mz607-mz617.dtsi b/arch/arm/boot/dts/ti/omap/motorola-mapphone-mz607-mz617.dtsi index a356b3a2f24e..b97ab2906950 100644 --- a/arch/arm/boot/dts/ti/omap/motorola-mapphone-mz607-mz617.dtsi +++ b/arch/arm/boot/dts/ti/omap/motorola-mapphone-mz607-mz617.dtsi @@ -4,6 +4,8 @@ #include "motorola-mapphone-common.dtsi" &keypad { + status = "okay"; + keypad,num-rows = <8>; keypad,num-columns = <8>; linux,keymap = <MATRIX_KEY(5, 0, KEY_VOLUMEUP)>, diff --git a/arch/arm/boot/dts/ti/omap/omap4-droid-bionic-xt875.dts b/arch/arm/boot/dts/ti/omap/omap4-droid-bionic-xt875.dts index 1d9000f84f1b..e72ac17fdd96 100644 --- a/arch/arm/boot/dts/ti/omap/omap4-droid-bionic-xt875.dts +++ b/arch/arm/boot/dts/ti/omap/omap4-droid-bionic-xt875.dts @@ -18,6 +18,8 @@ aliases { }; &keypad { + status = "okay"; + keypad,num-rows = <8>; keypad,num-columns = <8>; linux,keymap = < diff --git a/arch/arm/boot/dts/ti/omap/omap4-droid4-xt894.dts b/arch/arm/boot/dts/ti/omap/omap4-droid4-xt894.dts index cc3f3e1b65ea..62f87cf95f74 100644 --- a/arch/arm/boot/dts/ti/omap/omap4-droid4-xt894.dts +++ b/arch/arm/boot/dts/ti/omap/omap4-droid4-xt894.dts @@ -46,6 +46,8 @@ slider { }; &keypad { + status = "okay"; + keypad,num-rows = <8>; keypad,num-columns = <8>; linux,keymap = < diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts index e11d1931c42a..d51913620f06 100644 --- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts @@ -428,6 +428,8 @@ mpu9150: imu@68 { }; &keypad { + status = "okay"; + pinctrl-names = "default"; pinctrl-0 = <&keypad_pins>; keypad,num-rows = <2>; diff --git a/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi b/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi index c1afc49f456c..00f98991cc5c 100644 --- a/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi +++ b/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi @@ -1200,6 +1200,7 @@ keypad: keypad@0 { reg = <0x0 0x80>; interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; reg-names = "mpu"; + status = "disabled"; }; }; diff --git a/arch/arm/boot/dts/ti/omap/omap4-sdp.dts b/arch/arm/boot/dts/ti/omap/omap4-sdp.dts index b550105585a1..a04234b3be2a 100644 --- a/arch/arm/boot/dts/ti/omap/omap4-sdp.dts +++ b/arch/arm/boot/dts/ti/omap/omap4-sdp.dts @@ -531,6 +531,8 @@ &emif2 { }; &keypad { + status = "okay"; + keypad,num-rows = <8>; keypad,num-columns = <8>; linux,keymap = <0x00000012 /* KEY_E */ diff --git a/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi b/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi index 72849e1c95b0..af32ca329930 100644 --- a/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi +++ b/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi @@ -2449,6 +2449,7 @@ target-module@c000 { /* 0x4ae1c000, ap 11 1c.0 */ keypad: keypad@0 { compatible = "ti,omap4-keypad"; reg = <0x0 0x400>; + status = "disabled"; }; }; }; -- 2.43.0