Re: [PATCH 00/10] ASoC: ti: Improve probe error handling

Bui Duc Phuc <[email protected]>
Newsgroups org.kernel.vger.linux-omap,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound
Message-ID <CAABR9nE2-BTBNDrkAxd0Jg9RYwe48wfFynRQMwK55D7J1WeZSQ@mail.gmail.com>
Hi Cezary,

Thanks for the feedback.

>
> Which obviously you do not but the impression is there nonetheless.
>

There's no way I could hide anything from the reviewers anyway. :)


> If there are no dependencies between the 1) and 2), have all patches
> belonging to 1) lead the series before any 2)s pop up.
>
> Right now you have three outstanding patches in the middle of the set
> that clearly differentiate from "Use dev_err_probe() for error handling"
> pattern like if you are about to hide something.

From the earlier guard/scoped_guard series for Intel, I learned that you
prefer grouping patches by topic rather than mixing different kinds of
changes together.
I'm not sure whether other maintainers feel the same way, or would
rather prioritize what's more convenient for the developer preparing
the series.

Thanks again for the suggestion. I'll keep it in mind for future patch series.

Best regards,
Phuc
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.