Re: [PATCH] gpio: omap: handle clk_prepare failure in probe
Andreas Kemnade <[email protected]>
| Newsgroups | org.kernel.vger.linux-omap,org.kernel.vger.kernel-janitors,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 20 Aug 2026 11:19:00 +0200 Markus Elfring <[email protected]> wrote: > … > > Check the return value of clk_prepare in omap_gpio_probe. On failure, > > clear dbck_flag and return the error, preventing unbalanced > > clk_unprepare in remove or error paths. > > How do you think about to add any tags (like “Fixes” and “Cc”) accordingly? > About adding this to stable: does it bother anyone? Is this actually being used with clocks having prepare() ops? I do not see anything there. SoC-internal clocks are typically not so easy being rewired. To be clear, this should be fixed in -next to be prepared if something more fundamental in clock handling changes. Regards, Andreas > See also once more: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.2#n34 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2#n145 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2#n792 > > Regards, > Markus > >