Re: [PATCH v6 1/6] dt-bindings: gpio-mmio: Correct opencores GPIO
Linus Walleij <[email protected]>
| Newsgroups | org.kernel.vger.linux-openrisc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAD++jLnY058sc+S_rjor0fr++OvcrRt83OQwBg4h-dJb02UVzw@mail.gmail.com> |
On Thu, Jan 15, 2026 at 4:10 PM Stafford Horne <[email protected]> wrote: > In commit f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible string > for opencores,gpio") we marked opencores,gpio to be allowed with > brcm,bcm6345-gpio. This was wrong, opencores,gpio is not compatible with > brcm,bcm6345-gpio. It has a different register map and is 8-bit vs > Broadcom which is 32-bit. Change opencores,gpio to be a separate > compatible string for MMIO GPIO. > > Also, as this change rewrote the entire enum, I took this opportunity to > alphabetically sort the list. > > Fixes: f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible string for opencores,gpio") > Signed-off-by: Stafford Horne <[email protected]> > Reviewed-by: Geert Uytterhoeven <[email protected]> > Reviewed-by: Krzysztof Kozlowski <[email protected]> Reviewed-by: Linus Walleij <[email protected]> Yours, Linus Walleij