Re: [PATCH 1/5] parisc: Avoid compat syscalls when COMPAT=n
Helge Deller <[email protected]>
| Newsgroups | org.kernel.vger.linux-parisc |
|---|---|
| Message-ID | <[email protected]> |
On 4/8/26 17:22, Thomas Weißschuh wrote: > On 2026-04-08 00:27:10+0200, Helge Deller wrote: >> From: Helge Deller <[email protected]> >> >> Drop unnecessary code and syscall tables when we run a 64-bit >> kernel with conpat mode disabled. >> >> Signed-off-by: Helge Deller <[email protected]> >> --- >> arch/parisc/kernel/syscall.S | 11 +++++++---- > > The series currently does not disable the 32-bit vDSO when > CONFIG_COMPAT=n. Is this intentional? No, but I had not yet figured out how :-) > For me it would be convenient > disabling it to avoid the dependency on a 32-bit toolchain. Right. Will try. >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/arch/parisc/kernel/syscall.S b/arch/parisc/kernel/syscall.S >> index f58c4bccfbce..bc5421ca537f 100644 >> --- a/arch/parisc/kernel/syscall.S >> +++ b/arch/parisc/kernel/syscall.S >> @@ -241,7 +241,7 @@ linux_gateway_entry: >> /* Note! We cannot use the syscall table that is mapped >> nearby since the gateway page is mapped execute-only. */ >> >> -#ifdef CONFIG_64BIT >> +#if defined(CONFIG_64BIT) && defined(CONFIG_COMPAT) > > Shouldn't this also be just plain '#ifdef CONFIG_COMPAT' like in the > other patches? Yes. (will fix both), Thanks! Helge