Re: [PATCH v2 2/4] parisc: Makefile: use the regular compiler to build a native 32-bit vDSO

Hi Thomas,

On 4/8/26 20:18, Thomas Weißschuh wrote:
> When building a native 32-bit kernel $(CC) the compiler is obviously
> able to compile 32-bit code. There is no need to force the user to
> configure a dedicated 32-bit compiler.

I'm not sure, but still I think this logic of your patches #1 and #2
may break the builds for others.
That said, I'd prefer if we can get it working without your patches #1 and #2.
Can't we do without them?

I tried your patch series, but they fail to apply to my series or
upstream.

Helge


> 
> Use the regular compiler for the 32-bit vDSO when it is sufficient.
> 
> Signed-off-by: Thomas Weißschuh <[email protected]>
> ---
>   arch/parisc/Makefile | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index 92b769f4bbe7..ab8a93e773fb 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -49,6 +49,7 @@ ifdef cross_compiling
>       endif
>   endif
>   
> +ifdef CONFIG_64BIT
>   # Set default 32 bits cross compilers for vdso.
>   # This means that for 64BIT, both the 64-bit tools and the 32-bit tools
>   # need to be in the path.
> @@ -58,6 +59,9 @@ CROSS32_COMPILE := $(call cc-cross-prefix, \
>   	$(foreach a,$(CC_ARCHES_32), \
>   	$(foreach s,$(CC_SUFFIXES),$(a)-$(s)-)))
>   CROSS32CC := $(CROSS32_COMPILE)gcc
> +else
> +CROSS32CC := $(CC)
> +endif
>   export CROSS32CC
>   
>   ifdef CONFIG_DYNAMIC_FTRACE
>