Re: [PATCH v2 2/4] parisc: Makefile: use the regular compiler to build a native 32-bit vDSO
Helge Deller <[email protected]>
| Newsgroups | org.kernel.vger.linux-parisc,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 4/8/26 21:42, Thomas Weißschuh wrote:
> On 2026-04-08 21:01:45+0200, Helge Deller wrote:
>> On 4/8/26 20:18, Thomas Weißschuh wrote:
>>> When building a native 32-bit kernel $(CC) the compiler is obviously
>>> able to compile 32-bit code. There is no need to force the user to
>>> configure a dedicated 32-bit compiler.
>>
>> I'm not sure, but still I think this logic of your patches #1 and #2
>> may break the builds for others.
>> That said, I'd prefer if we can get it working without your patches #1 and #2.
>> Can't we do without them?
>
> They are mostly do avoid hacks in the nolibc testsuite.
> I'll drop them and use this instead:
> --- a/tools/testing/selftests/nolibc/run-tests.sh
> +++ b/tools/testing/selftests/nolibc/run-tests.sh
> @@ -175,6 +175,10 @@ test_arch() {
> fi
> MAKE=(make -f Makefile.nolibc -j"${nproc}" XARCH="${arch}" CROSS_COMPILE="${cross_compile}" LLVM="${llvm}" O="${build_dir}")
>
> + if [ "$arch" = "parisc32" ]; then
> + MAKE+=("CROSS32CC=${cross_compile}gcc")
can you try if
MAKE += " ARCH=parisc"
works too?
> However in the long-term it would be nice not the need it anymore.
> Afaik is parisc the only architecture which needs a special compiler
> specification for the native vDSO.
actually it doesn't. It will figure out itself.
>> I tried your patch series, but they fail to apply to my series or
>> upstream.
>
> These patches are currently based on nolibc/for-next
>
> https://git.kernel.org/pub/scm/linux/kernel/git/nolibc/linux-nolibc.git/log/?h=for-next
Ok.
Thanks!
Helge