Re: [PATCH] Input: gscps2 - advance receive buffer write index
Dmitry Torokhov <[email protected]>
| Newsgroups | org.kernel.vger.linux-parisc,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Jun 24, 2026 at 05:47:39PM +0800, raoxu wrote: > From: Xu Rao <[email protected]> > > Commit 44f920069911 ("Input: gscps2 - use guard notation when > acquiring spinlock") moved the receive loop into gscps2_read_data() > and gscps2_report_data(). > > While moving the code, it preserved the writes to > buffer[ps2port->append], but omitted the following producer index > update from the original loop: > > ps2port->append = (ps2port->append + 1) & BUFFER_SIZE; > > As a result, append never advances. Since gscps2_report_data() only > reports bytes while act != append, the receive buffer always appears > empty and no keyboard or mouse data reaches the serio core. > > Restore the omitted index update. > > Fixes: 44f920069911 ("Input: gscps2 - use guard notation when acquiring spinlock") > Cc: [email protected] # 6.13+ > Signed-off-by: Xu Rao <[email protected]> Applied, thank you. -- Dmitry