Re: [PATCH 05/30] mm/rmap: update mm/interval_tree.c comments
Gregory Price <[email protected]>
| Newsgroups | org.kernel.vger.linux-parisc,dev.linux.lists.damon,dev.linux.lists.iommu,dev.linux.lists.nvdimm,org.freedesktop.lists.dri-devel,org.kernel.vger.kvm,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-sgx,org.kernel.vger.linux-tegra,org.kernel.vger.linux-trace-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <akKWvnU2Ua-8ceSb@gourry-fedora-PF4VCD3F> |
On Mon, Jun 29, 2026 at 01:23:16PM +0100, Lorenzo Stoakes wrote: > Update the file comment to clarify that both file-backed and anonymous > interval trees are provided, referencing the relevant data types for > clarity. > Isn't this self-evident by nature of the function definitions? (one takes a vm_area_struct, the other takes an anon_vma_chain) > - VM_BUG_ON_VMA(vma_start_pgoff(node) != vma_start_pgoff(prev), node); > + VM_WARN_ON_ONCE_VMA(vma_start_pgoff(node) != vma_start_pgoff(prev), node); > For my own edification - I know not to add new BUG(), should I be converting BUG->WARN/something when i find them in areas i happen to be working in? ~Gregory