Re: [PATCH 06/30] mm/rmap: parameterise vma_interval_tree_*() by address_space
Lorenzo Stoakes <[email protected]>
| Newsgroups | org.kernel.vger.linux-parisc,dev.linux.lists.damon,dev.linux.lists.iommu,dev.linux.lists.nvdimm,org.freedesktop.lists.dri-devel,org.kernel.vger.kvm,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-sgx,org.kernel.vger.linux-tegra,org.kernel.vger.linux-trace-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <akTkRC7gPzdibXhU@lucifer> |
On Tue, Jun 30, 2026 at 05:19:16PM +0100, Pedro Falcato wrote: > On Mon, Jun 29, 2026 at 01:23:17PM +0100, Lorenzo Stoakes wrote: > > The file-backed mapping interval tree functions vma_interval_tree_*() > > accept a raw rb_root_cached pointer to determine the tree in which they are > > operating. > > > > However, in each case, this is always associated with an address_space data > > type. > > > > So simply pass a pointer to that instead to simplify the code, and more > > clearly differentiate between these operations and those concerning > > anonymous mappings. > > > > While we're here, make the generated interval tree functions static as they > > do not need to be used externally (any previously existing external users > > have now been removed). > > > > We also rename VMA parameters from 'node' to 'vma' as calling this a node > > is simply confusing, update the input index types to pgoff_t since they > > reference page offsets and rename the parameters to pgoff_start and > > pgoff_last. > > > > No functional change intended. > > > > Signed-off-by: Lorenzo Stoakes <[email protected]> > > 1) This is fantastic > 2) I need to rebase my local work :) > > Reviewed-by: Pedro Falcato <[email protected]> > > -- > Pedro 1) thanks :) 2) sorry :P Cheers, Lorenzo