Re: [PATCH v5 2/3] arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Incorrect GPIO polarity for the W_DISABLE2# signal (`w-disable2-gpios`) on the M.2 E key connector.
--

--- Patch [2]: [PATCH v5 2/3] arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector ---
commit e61546d91652b5590b157402a4ee5bfc16fe5075
Author: Krishna Chaitanya Chundru <[email protected]>

arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector

The Eliza EVK board features an M.2 E key connector connected to PCIe0.
Enable the PCIe0 root port and its QMP PHY with the necessary RPMH
regulator supplies. The M.2 slot's 3.3V supply rail is GPIO-controlled
via a TCA9538 I/O expander on I2C4.

> diff --git a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
> index e47b24f8b8277..b35fffb509765 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
[ ... ]
> +	connector-0 {
> +		compatible = "pcie-m2-e-connector";
> +		vpcie3v3-supply = <&vreg_pcie_m_3p3>;
> +		w-disable1-gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
> +		w-disable2-gpios = <&pm8550vs_g_gpios 4 GPIO_ACTIVE_HIGH>;

[Severity: High]
Does this code invert the expected logic for the Bluetooth radio?

The W_DISABLE2 signal on an M.2 E key connector is physically active-low
according to the PCI Express M.2 specification.

Using GPIO_ACTIVE_HIGH causes the kernel power sequencing framework to
drive the GPIO low when attempting to logically deassert the signal and
enable the device, which will effectively disable the radio instead.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2